From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] fix #4430: add UTC timezone as option to installer
Date: Wed, 15 Mar 2023 14:23:09 +0100 [thread overview]
Message-ID: <8ea5bbf5-127e-1a8c-15d2-e092b0ddea7d@proxmox.com> (raw)
In-Reply-To: <20230315122635.286988-1-c.heiss@proxmox.com>
Am 15/03/2023 um 13:26 schrieb Christoph Heiss:
> The 'Etc/UTC' timezone does not have a definite 2-letter country code
> assigned. 'xx' was choosen on the basis that this hopefully will never
> be assigned to any real country in the future, but a small collision
> check won't hurt either.
>
> This also means it does not have an entry in either the ISO-codes
> definition file nor the zoneinfo table, thus needing to define it
> manually.
>
> Using just 'UTC' as timezone (name) also matches what PVE/PMG/PBS do in
> their UI.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Some bike-shedding: If there is a better suggestion on what country code
> to choose, I'll happily change it.
Something like xx is fine in general, it's the simplest way to integrate this,
so I'd base the exact used letters purely on sorting,
>
> Also, although the correct timezone name is 'Etc/UTC', I chose 'UTC' as
> "country name" to display in the installer to make it easier to find for
> users, as they probably will just type 'UTC' in there at first, rather
> than 'Etc'.
>
That's fine too.
What I don't like as much that one has to set the country to the timezone,
which is confusing UX and will be subtle to most.
Better ways might be:
- add an explicit "Use UTC" checkbox that grey's out the country/timezone
selection then. Disadvantage here would be taking up extra space and expanding
the user input amount, which goes a bit against our "as simple as possible"
approach for the installer
- Add UTC always to the time-zone selection, independent of what country is
selected. This keeps the selection where it belongs, and allows to quickly
change to UTC without any typing/searching required (at least for most countries)
From a gut feeling I'd go for the second option, but didn't checked out how the
implementation would then look like.
next prev parent reply other threads:[~2023-03-15 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 12:26 Christoph Heiss
2023-03-15 13:23 ` Thomas Lamprecht [this message]
2023-03-16 9:17 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea5bbf5-127e-1a8c-15d2-e092b0ddea7d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox