From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [pve-cluster/pve-network] move macs.db from priv/ to sdn/
Date: Mon, 18 Nov 2024 22:22:34 +0100 [thread overview]
Message-ID: <8e7b3b5e-aaf5-4c44-8b19-383b2055a542@proxmox.com> (raw)
In-Reply-To: <20241118205537.3136251-1-s.ivanov@proxmox.com>
Am 18.11.24 um 21:55 schrieb Stoiko Ivanov:
> while looking through the changes in pve-network, and testing the
> port-isolation series I saw the move of priv/ipam.db to
> sdn/pve-ipam-state.json:
>
> https://git.proxmox.com/?p=pve-network.git;a=commitdiff;h=0f48bc6561f2fd901f2665387b4954c8105614e0
>
> Following the argumentation the mac-cache file should probably also be
> moved to a non-root-exclusive directory.
>
> From a quick glance the remaining files in `priv/` do belong there.
>
> minimally tested this on my machine.
>
> pve-cluster:
> Stoiko Ivanov (1):
> cfs: add 'sdn/mac-cache.json' to observed files
>
> src/PVE/Cluster.pm | 3 ++-
> src/pmxcfs/status.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> pve-network:
> Stoiko Ivanov (1):
> ipam: move mac-cache.db to unprivileged sdn/ subdirectory
>
> src/PVE/Network/SDN/Ipams.pm | 29 +++++++++++++++++++++++++++--
> 1 file changed, 27 insertions(+), 2 deletions(-)
>
applied, huge thanks for catching this early enough!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-18 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 20:55 [pve-devel] " Stoiko Ivanov
2024-11-18 20:55 ` [pve-devel] [PATCH cluster 1/1] cfs: add 'sdn/mac-cache.json' to observed files Stoiko Ivanov
2024-11-18 20:55 ` [pve-devel] [pve-network 1/1] ipam: move mac-cache.db to unprivileged sdn/ subdirectory Stoiko Ivanov
2024-11-18 21:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e7b3b5e-aaf5-4c44-8b19-383b2055a542@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox