From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: [pve-devel] applied: [PATCH container] fix #4765: pct: do not report cpu usage
Date: Tue, 18 Jul 2023 16:00:00 +0200 [thread overview]
Message-ID: <8e39ef74-2fbb-c742-ccce-d94d5e52c8ac@proxmox.com> (raw)
In-Reply-To: <20230629113423.18311-1-m.sandoval@proxmox.com>
Am 29/06/2023 um 13:34 schrieb Maximiliano Sandoval:
> When running `pct status VMID` the variable
> $last_proc_vmid_stat->{$vmid} is not set and pct reports no cpu usage.
>
> For consistency with the qt command we do not print the cpu usage.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> This is a different approach that the one tried at
> https://lists.proxmox.com/pipermail/pve-devel/2023-June/057771.html.
>
> While we could run the computation twice after a time delta to get *a* number
> there are many open questions, like how would a user interpret this value, and
> how is this time delta going to be documented, etc.
>
> src/PVE/CLI/pct.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied this one, thanks!
as mentioned to Phillip off list, we can always re-add it with a "better" logic
(for some definition of better) if there's really request for it that cannot be
satisfied by just using the API.
prev parent reply other threads:[~2023-07-18 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 11:34 [pve-devel] " Maximiliano Sandoval
2023-07-18 14:00 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e39ef74-2fbb-c742-ccce-d94d5e52c8ac@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox