* [pve-devel] [PATCH qemu-server] status: fix description of qmpstatus property
@ 2023-03-03 7:35 Fiona Ebner
2023-06-14 11:16 ` Fiona Ebner
2023-06-14 11:34 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Fiona Ebner @ 2023-03-03 7:35 UTC (permalink / raw)
To: pve-devel
Using the word 'agent' is highly confusing here as there is no QMP
agent and thus wrongly suggests that the value is related to the
guest agent[0].
[0]: https://forum.proxmox.com/threads/123590/post-537716
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 40be44db..0ded3ce3 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2867,7 +2867,7 @@ our $vmstatus_return_properties = {
optional => 1,
},
qmpstatus => {
- description => "QEMU QMP agent status.",
+ description => "VM run state from the 'query-status' QMP monitor command.",
type => 'string',
optional => 1,
},
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] [PATCH qemu-server] status: fix description of qmpstatus property
2023-03-03 7:35 [pve-devel] [PATCH qemu-server] status: fix description of qmpstatus property Fiona Ebner
@ 2023-06-14 11:16 ` Fiona Ebner
2023-06-14 11:34 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2023-06-14 11:16 UTC (permalink / raw)
To: pve-devel
Ping
Am 03.03.23 um 08:35 schrieb Fiona Ebner:
> Using the word 'agent' is highly confusing here as there is no QMP
> agent and thus wrongly suggests that the value is related to the
> guest agent[0].
>
> [0]: https://forum.proxmox.com/threads/123590/post-537716
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 40be44db..0ded3ce3 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -2867,7 +2867,7 @@ our $vmstatus_return_properties = {
> optional => 1,
> },
> qmpstatus => {
> - description => "QEMU QMP agent status.",
> + description => "VM run state from the 'query-status' QMP monitor command.",
> type => 'string',
> optional => 1,
> },
^ permalink raw reply [flat|nested] 3+ messages in thread* [pve-devel] applied: [PATCH qemu-server] status: fix description of qmpstatus property
2023-03-03 7:35 [pve-devel] [PATCH qemu-server] status: fix description of qmpstatus property Fiona Ebner
2023-06-14 11:16 ` Fiona Ebner
@ 2023-06-14 11:34 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-06-14 11:34 UTC (permalink / raw)
To: Proxmox VE development discussion, Fiona Ebner
Am 03/03/2023 um 08:35 schrieb Fiona Ebner:
> Using the word 'agent' is highly confusing here as there is no QMP
> agent and thus wrongly suggests that the value is related to the
> guest agent[0].
>
> [0]: https://forum.proxmox.com/threads/123590/post-537716
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-14 11:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-03 7:35 [pve-devel] [PATCH qemu-server] status: fix description of qmpstatus property Fiona Ebner
2023-06-14 11:16 ` Fiona Ebner
2023-06-14 11:34 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox