Re: [PATCH docs/guest-common/manager v2 0/4] fix #6464: backup: add backup retry strategies

[Jonas Theisen <j.theisen@proxmox.com>]

On 11/11/26 10:35, Jakob Klocker wrote:
> <snip>
>
> If a guest succeeds on a retry, it is reported as successful in the
> notification and no error is counted. If it still fails after the last
> retry, the job finishes with errors as before. Task logging has been
> switched to append mode so the log contains the complete transcript of
> all attempts.

I personally would prefer if a transient failure would still be
reported as a warning. Retries are good to not miss the backup
completely but it still in most cases means something is wrong.
> I kept the retry options in the advanced tab of the backup job window,
> but I'm not sure whether they should be moved to the general tab.
> Opinions on this are appreciated.

A more general issue is the combination of retries with the --stdout
parameter, where the tar gets written to a stdout instead of a file.
The resulting stream gets corrupted by a retry so probably the CLI
should just bail in that combination.
>
> Testing info:
> When testing I'd suggest to fail the backup by locking and
> unlocking the guest with following commands:
> `qm set <VMID> -lock backup`
> `qm unlock <VMID>`

I also tested this in combination with an unreachable PBS by just
yanking out the connection on the PBS side.
This caused the backup task to fail even before the retries since
it could not activate the storage.
Since i assume this is one of the more common failure modes
i think that should be covered by a retry.
> <snip>