public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 0/4] followups for vzdump scheduling2
Date: Wed, 10 Nov 2021 18:18:00 +0100	[thread overview]
Message-ID: <8d4c64d8-8e22-e1fb-e84e-7bd6321c9c41@proxmox.com> (raw)
In-Reply-To: <20211110140256.1863209-1-d.csapak@proxmox.com>

On 10.11.21 15:02, Dominik Csapak wrote:
> * fixes the saving/loading of the 'prune-backups' field (oops)
> * adds correct validation for id
> * adds a comment field for jobs

still missing any documentation update ;)

I'd move out the schedule format section from the replication chapter to an appendix
(or some other, more central place), extend backups about the new scheduling stuff.

also the ID is now some in-between stuff, one needs to enter it but it won't be
shown in the grid anyway, so either:

1 go the full way like PBS sync/verify/... jobs and just auto-generate, less inputs
  or the user is normally better UX and they can express comments already in the,
  well new comment field.
2 hide it only for the old ones, rather too confusing
3 allow to edit it for existing jobs, would be a bit weird for the API but as we have
  the digest mechanism and can  do (pseudo call) `PUT /.../backup/<oldid>?id=<newid>`
  it could work without to much confusion..

1 would be the least commitment now, 2 is meh and 3 is more commitment now and may
open a precedent for users to nag about allowing this in more places (where it may
be way harder, a nuisance or plain impossible)

What do you think?




  parent reply	other threads:[~2021-11-10 17:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 14:02 Dominik Csapak
2021-11-10 14:02 ` [pve-devel] [PATCH manager 1/4] Jobs/VZDump: encode/decode 'prune-backups' where needed Dominik Csapak
2021-11-10 14:02 ` [pve-devel] [PATCH manager 2/4] ui: dc/BackupEdit: use correct validation Dominik Csapak
2021-11-10 14:02 ` [pve-devel] [PATCH manager 3/4] api: backup/jobs: add comment field to jobs Dominik Csapak
2021-11-10 14:02 ` [pve-devel] [PATCH manager 4/4] ui: dc/Backup: add comment field and column Dominik Csapak
2021-11-10 17:18 ` Thomas Lamprecht [this message]
2021-11-10 20:37 ` [pve-devel] applied-series: [PATCH manager 0/4] followups for vzdump scheduling2 Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d4c64d8-8e22-e1fb-e84e-7bd6321c9c41@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal