From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] api: clone: sort vm disks to keep numbers consistent
Date: Wed, 26 May 2021 17:36:11 +0200 [thread overview]
Message-ID: <8d07c8b6-dc0c-ef31-d928-0dbf172634fa@proxmox.com> (raw)
In-Reply-To: <20210526141917.111469-1-l.stechauner@proxmox.com>
On 26.05.21 16:19, Lorenz Stechauner wrote:
> reported by user in forum:
> https://forum.proxmox.com/threads/problem-when-copying-template-with-2-discs.89851/
>
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
> PVE/API2/Qemu.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
But note that this sorts drives with different digit-size of the decimal part
also wrong, depnding on POV, e.g., drive1, drive2 and drive10 would sort:
drive1
drive10
drive2
But IMO still lots better that before, especially as they're grouped by bus
type too.
prev parent reply other threads:[~2021-05-26 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 14:19 [pve-devel] " Lorenz Stechauner
2021-05-26 15:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d07c8b6-dc0c-ef31-d928-0dbf172634fa@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox