[pve-devel] [PATCH manager] ui: fix novnc scaling radio buttons

[pve-devel] [PATCH manager] ui: fix novnc scaling radio buttons

[Dominik Csapak]

when having selected 'off', the next start of the window has both
radiobuttons selected and no change is possible anymore. It seems that
the 'checked: true' triggers only after the 'init' function.

So instead remove the 'checked: true', and add the default in the init
function.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/window/Settings.js | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/www/manager6/window/Settings.js b/www/manager6/window/Settings.js
index 4aa7137c..b151adcd 100644
--- a/www/manager6/window/Settings.js
+++ b/www/manager6/window/Settings.js
@@ -34,10 +34,8 @@ Ext.define('PVE.window.Settings', {
 
 	    var username = sp.get('login-username') || Proxmox.Utils.noneText;
 	    me.lookupReference('savedUserName').setValue(Ext.String.htmlEncode(username));
-	    var vncMode = sp.get('novnc-scaling');
-	    if (vncMode !== undefined) {
-		me.lookupReference('noVNCScalingGroup').setValue({ noVNCScalingField: vncMode });
-	    }
+	    var vncMode = sp.get('novnc-scaling') || 'scale';
+	    me.lookupReference('noVNCScalingGroup').setValue({ noVNCScalingField: vncMode });
 
 	    let summarycolumns = sp.get('summarycolumns', 'auto');
 	    me.lookup('summarycolumns').setValue(summarycolumns);
@@ -379,7 +377,6 @@ Ext.define('PVE.window.Settings', {
 				name: 'noVNCScalingField',
 				inputValue: 'scale',
 				boxLabel: 'Local Scaling',
-				checked: true,
 			    }, {
 				xtype: 'radiofield',
 				name: 'noVNCScalingField',
-- 
2.30.2

[pve-devel] applied: [PATCH manager] ui: fix novnc scaling radio buttons

[Thomas Lamprecht]

On 11.01.22 11:26, Dominik Csapak wrote:
> when having selected 'off', the next start of the window has both
> radiobuttons selected and no change is possible anymore. It seems that
> the 'checked: true' triggers only after the 'init' function.
> 
> So instead remove the 'checked: true', and add the default in the init
> function.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/window/Settings.js | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
>

applied, thanks!