[pve-devel] [PATCH installer 0/2] tui: throw setup error if no network interfaces were found

[pve-devel] [PATCH installer 0/2] tui: throw setup error if no network interfaces were found

[Christoph Heiss]

Currently, the TUI does not error out like the GUI if no network
interfaces are found, so remedy that. 

Also, while testing, noticed that if an early/setup error is thrown in
the installer, no background header gets displayed - since it uses a
completely different screen setup codepath. 

Christoph Heiss (2):
  tui: show background header on fatal setup error
  installer-common: throw setup error if no network interfaces were
    found

 proxmox-installer-common/src/setup.rs | 2 ++
 proxmox-tui-installer/src/main.rs     | 1 +
 2 files changed, 3 insertions(+)

-- 
2.46.0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH installer 1/2] tui: show background header on fatal setup error

[Christoph Heiss]

This was missing, as it was only applied for the main installation UI -
the setup error has its own screen setup codepath entirely.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 proxmox-tui-installer/src/main.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs
index 3fb87a7..b1f11cb 100644
--- a/proxmox-tui-installer/src/main.rs
+++ b/proxmox-tui-installer/src/main.rs
@@ -219,6 +219,7 @@ fn installer_setup_late(siv: &mut Cursive) {
 }
 
 fn initial_setup_error(siv: &mut CursiveRunnable, message: &str) -> ! {
+    siv.add_fullscreen_layer(InstallerBackgroundView::new());
     siv.add_layer(
         Dialog::around(TextView::new(message))
             .title("Installer setup error")
-- 
2.46.0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH installer 2/2] installer-common: throw setup error if no network interfaces were found

[Christoph Heiss]

We do that check already in the GUI, so add it for TUI (and by
extension, the auto-installer) too.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 proxmox-installer-common/src/setup.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/proxmox-installer-common/src/setup.rs b/proxmox-installer-common/src/setup.rs
index e4e609b..e9a5b96 100644
--- a/proxmox-installer-common/src/setup.rs
+++ b/proxmox-installer-common/src/setup.rs
@@ -193,6 +193,8 @@ pub fn installer_setup(in_test_mode: bool) -> Result<(SetupInfo, LocaleInfo, Run
     runtime_info.disks.sort();
     if runtime_info.disks.is_empty() {
         Err("The installer could not find any supported hard disks.".to_owned())
+    } else if runtime_info.network.interfaces.is_empty() {
+        Err("The installer could not find any supported network interface cards.".to_owned())
     } else {
         Ok((installer_info, locale_info, runtime_info))
     }
-- 
2.46.0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer 0/2] tui: throw setup error if no network interfaces were found

[Aaron Lauterer]

Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>

On  2024-10-24  11:00, Christoph Heiss wrote:
> Currently, the TUI does not error out like the GUI if no network
> interfaces are found, so remedy that.
> 
> Also, while testing, noticed that if an early/setup error is thrown in
> the installer, no background header gets displayed - since it uses a
> completely different screen setup codepath.
> 
> Christoph Heiss (2):
>    tui: show background header on fatal setup error
>    installer-common: throw setup error if no network interfaces were
>      found
> 
>   proxmox-installer-common/src/setup.rs | 2 ++
>   proxmox-tui-installer/src/main.rs     | 1 +
>   2 files changed, 3 insertions(+)
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH installer 0/2] tui: throw setup error if no network interfaces were found

[Thomas Lamprecht]

Am 24/10/2024 um 11:00 schrieb Christoph Heiss:
> Currently, the TUI does not error out like the GUI if no network
> interfaces are found, so remedy that. 
> 
> Also, while testing, noticed that if an early/setup error is thrown in
> the installer, no background header gets displayed - since it uses a
> completely different screen setup codepath. 
> 
> Christoph Heiss (2):
>   tui: show background header on fatal setup error
>   installer-common: throw setup error if no network interfaces were
>     found
> 
>  proxmox-installer-common/src/setup.rs | 2 ++
>  proxmox-tui-installer/src/main.rs     | 1 +
>  2 files changed, 3 insertions(+)
> 


applied series, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel