From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer 0/2] tui: throw setup error if no network interfaces were found
Date: Wed, 30 Oct 2024 10:02:12 +0100 [thread overview]
Message-ID: <8caa0124-4c8b-4966-a287-1ff6928857f1@proxmox.com> (raw)
In-Reply-To: <20241024090043.181653-1-c.heiss@proxmox.com>
Am 24/10/2024 um 11:00 schrieb Christoph Heiss:
> Currently, the TUI does not error out like the GUI if no network
> interfaces are found, so remedy that.
>
> Also, while testing, noticed that if an early/setup error is thrown in
> the installer, no background header gets displayed - since it uses a
> completely different screen setup codepath.
>
> Christoph Heiss (2):
> tui: show background header on fatal setup error
> installer-common: throw setup error if no network interfaces were
> found
>
> proxmox-installer-common/src/setup.rs | 2 ++
> proxmox-tui-installer/src/main.rs | 1 +
> 2 files changed, 3 insertions(+)
>
applied series, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-10-30 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 9:00 [pve-devel] " Christoph Heiss
2024-10-24 9:00 ` [pve-devel] [PATCH installer 1/2] tui: show background header on fatal setup error Christoph Heiss
2024-10-24 9:00 ` [pve-devel] [PATCH installer 2/2] installer-common: throw setup error if no network interfaces were found Christoph Heiss
2024-10-29 14:56 ` [pve-devel] [PATCH installer 0/2] tui: " Aaron Lauterer
2024-10-30 9:02 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8caa0124-4c8b-4966-a287-1ff6928857f1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox