* [pve-devel] [PATCH manager] ui: Utils: remove unnecessary render_kvm_vga_driver
@ 2022-03-09 14:09 Dominik Csapak
2022-04-26 7:10 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2022-03-09 14:09 UTC (permalink / raw)
To: pve-devel
the 'value' here is already the rendered text, passing it through
render again does not make sense
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/Utils.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index aafe359a..d6aeaf31 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -653,9 +653,9 @@ Ext.define('PVE.Utils', {
},
kvm_vga_driver_array: function() {
- var data = [['__default__', PVE.Utils.render_kvm_vga_driver('')]];
+ var data = [['__default__', Proxmox.Utils.defaultText]];
Ext.Object.each(PVE.Utils.kvm_vga_drivers, function(key, value) {
- data.push([key, PVE.Utils.render_kvm_vga_driver(value)]);
+ data.push([key, value]);
});
return data;
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: Utils: remove unnecessary render_kvm_vga_driver
2022-03-09 14:09 [pve-devel] [PATCH manager] ui: Utils: remove unnecessary render_kvm_vga_driver Dominik Csapak
@ 2022-04-26 7:10 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-04-26 7:10 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 09.03.22 15:09, Dominik Csapak wrote:
> the 'value' here is already the rendered text, passing it through
> render again does not make sense
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/Utils.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
same held true for the kvm_keymap_array and console_viewer_array, actually I reworked the whole three quite
a bit more, using Object.entries() directly allows to shave off quite some code, order seems till fine here
too.
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-26 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-09 14:09 [pve-devel] [PATCH manager] ui: Utils: remove unnecessary render_kvm_vga_driver Dominik Csapak
2022-04-26 7:10 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox