public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Leo Nunner <l.nunner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] fix #3004: show progress of offline migration in task log
Date: Mon, 14 Nov 2022 13:23:27 +0100	[thread overview]
Message-ID: <8c6067bb-a656-431b-df29-9b65b6149f89@proxmox.com> (raw)
In-Reply-To: <190c1ae8-721e-88a0-3c82-f8698dce7e4c@proxmox.com>

On 11/14/22 13:12, Thomas Lamprecht wrote:

> Am 14/11/2022 um 13:01 schrieb Leo Nunner:
>> dd supports a 'status' flag, which enables it to show the copied bytes,
>> duration, and the transfer rate, which then get printed to stderr.
>>
> can you post an excerpt of what it looks like and how frequent it outputs?

Currently, the output looks as following:

    2022-11-14 12:01:00 236978176 bytes (237 MB, 226 MiB) copied, 1 s,
    237 MB/s
    2022-11-14 12:01:01 596377600 bytes (596 MB, 569 MiB) copied, 2 s,
    298 MB/s
    2022-11-14 12:01:02 947388416 bytes (947 MB, 904 MiB) copied, 3 s,
    316 MB/s
    2022-11-14 12:01:03 1308295168 bytes (1.3 GB, 1.2 GiB) copied, 4 s,
    327 MB/s
    2022-11-14 12:01:04 1673527296 bytes (1.7 GB, 1.6 GiB) copied, 5 s,
    335 MB/s
    […]

> as unlike a TTY it cannot tell the console to override existing lines, so I
> guess this will do some periodic printing?

Yes, as of right now, it prints a new line every second. Maybe one 
option to make it "prettier"
would be to limit the lines printed (by, say, only printing every nth 
line/second), which should
be rather simple to implement by matching the dd output in Storage.pm, 
where log lines are
already being parsed [1].

[1] https://git.proxmox.com/?p=pve-storage.git;a=blob;f=PVE/Storage.pm#l824


  reply	other threads:[~2022-11-14 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 12:01 Leo Nunner
2022-11-14 12:12 ` Thomas Lamprecht
2022-11-14 12:23   ` Leo Nunner [this message]
2022-11-14 12:51     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c6067bb-a656-431b-df29-9b65b6149f89@proxmox.com \
    --to=l.nunner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal