From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] tui: multiply the disk size back into bytes
Date: Wed, 21 Jun 2023 16:36:51 +0200 [thread overview]
Message-ID: <8c5c2ce7-98ad-de35-9685-3facc5248987@proxmox.com> (raw)
In-Reply-To: <20230621140035.381027-1-s.sterz@proxmox.com>
Am 21/06/2023 um 16:00 schrieb Stefan Sterz:
> previously the installer correctly divided the value when using them
> for the `FloatEditView`, but forgot to multiply the value again when
> retrieving it after editing. this commit fixes that
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> tested this only locally and didn't build the installer completelly.
> i am not sure if the installer handles this value correctly once it
> is forwarded to the perl installer. if the perl installer expects
> bytes here, it should work just fine, though.
no it doesn't it expects Gigabyte in floats, see:
https://git.proxmox.com/?p=pve-installer.git;a=commitdiff;h=9a2d64977f73cec225c407ff13765ef02e2ff9e9
next prev parent reply other threads:[~2023-06-21 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 14:00 Stefan Sterz
2023-06-21 14:36 ` Thomas Lamprecht [this message]
2023-06-22 6:56 ` Stefan Sterz
2023-06-22 7:00 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5c2ce7-98ad-de35-9685-3facc5248987@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox