Re: [pve-devel] [PATCH edk2-firmware v2 3/3] Add SCSI in NCCFV for TD guest

[Anton Iacobaeus <anton.iacobaeus@canarybit.eu>]

On 10/7/25 17:24, Fiona Ebner wrote:
> Am 04.10.25 um 3:23 PM schrieb Anton Iacobaeus:
>> From: Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
>>
>> The FV in `IntelTdx/IntelTdxX64.fdf` was split into two FVs, one for a
>> TD guest and one for non-cc guest. The SCSI driver was moved to the
>> non-cc NCCFV. In order for PVE to use an image with SCSI include the
>> SCSI driver in the FV for TD guest.
> 
> Did you already ask upstream whether they would be willing to include
> SCSI for the TD guest or is there no interest? Some of it is already
> guarded via _ENABLE flags anyways. I'm fine with going with this, but
> it's always nice to have no more diff than necessary to upstream.
> 

We asked upstream and they said that there is no architecture issue with
the SCSI driver, but it is a matter of validation. As of now there are
no plans to include it, but an official request for it could be made.
The process will likely be lengthy however and they also mentioned that
including the driver manually is a good option.

>> Signed-off-by: Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
>> Signed-off-by: Anton Iacobaeus <anton.iacobaeus@canarybit.eu>
> 
> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
> 
> Unfortunately, mailman ate the special line endings in the diff below,
> so it's necessary to fix them up locally to be able to build the
> package. Should there be another version of the series, please use
> --transfer-encoding=base64 when sending the message with git.
> 

Thank you for the review! I will clean up some things and make a v3.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel