From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH common v4 1/7] tools: add check_list_empty function
Date: Tue, 10 Sep 2024 08:56:25 +0200 [thread overview]
Message-ID: <8c2bb01f-02d1-4e92-87a2-3efec4ef8bfe@proxmox.com> (raw)
In-Reply-To: <28159577-dd72-4a23-b93f-b1382a235834@proxmox.com>
On 2024-09-09 16:02, Fiona Ebner wrote:
> Am 29.07.24 um 13:55 schrieb Aaron Lauterer:
>> In some situations we don't want a total empty list. I opted for a
>> dedicated function instead of integrating it as error in the
>> `split_list` function. It is used in many places and the potential
>> fallout from unintended behavior changes is too big.
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> Tested-By: Stefan Hanreich <s.hanreich@proxmox.com>
>> Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>> changes since: v3: none
>> v2: newly added
>>
>> src/PVE/Tools.pm | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
>> index bd305bd..f796bd0 100644
>> --- a/src/PVE/Tools.pm
>> +++ b/src/PVE/Tools.pm
>> @@ -718,6 +718,14 @@ sub split_list {
>> return @data;
>> }
>>
>> +sub check_list_empty {
>> + my ($list) = @_;
>> + if (scalar(PVE::Tools::split_list($list)) < 1) {
>> + return 0;
>> + }
>> + return 1;
>> +}
>
> This can be very confusing IMHO. Intuitively, I'd expect the expression
> check_list_empty($list) to be truthy if $list is empty. I'd rather call
> it list_not_empty. But looking at the caller you introduce later, it
> might be better to avoid the double negative, flip the truth table and
> call it list_is_empty.
>
thanks! sounds like a good idea. I will wait a bit before sending a v5.
>> +
>> sub trim {
>> my $txt = shift;
>>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-09-10 6:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 11:55 [pve-devel] [PATCH common, widget-toolkit, manager v4 0/7] fix #3893: make bridge vids configurable Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH common v4 1/7] tools: add check_list_empty function Aaron Lauterer
2024-09-09 14:02 ` Fiona Ebner
2024-09-10 6:56 ` Aaron Lauterer [this message]
2024-07-29 11:55 ` [pve-devel] [PATCH common v4 2/7] fix #3893: network: add vlan id and range parameter definitions Aaron Lauterer
2024-09-10 9:21 ` Fiona Ebner
2024-07-29 11:55 ` [pve-devel] [PATCH common v4 3/7] inotify: interfaces: make sure bridge_vids use space as separator Aaron Lauterer
2024-09-10 9:37 ` Fiona Ebner
2024-07-29 11:55 ` [pve-devel] [PATCH widget-toolkit v4 4/7] fix #3892: Network: add bridge vids field for bridge_vids Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH widget-toolkit v4 5/7] Network: add explanation for bridge vids field Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH manager v4 6/7] fix #3893: api: network: add bridge_vids parameter Aaron Lauterer
2024-07-29 11:55 ` [pve-devel] [PATCH manager v4 7/7] fix #3893: ui: network: enable bridge_vids field Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c2bb01f-02d1-4e92-87a2-3efec4ef8bfe@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox