Re: [PATCH qemu-server] qemuserver: make base path of libGL and libEGL libraries architecture aware

[Dominik Csapak <d.csapak@proxmox.com>]

On 7/16/26 5:27 AM, Kaiyang Wu wrote:
> 'print_vga_device' assumed x86_64 library path to look for 'libGL.so.1'
> and 'libEGL.so.1', which leads to missing libraries error regardless of
> whether 'libgl1' and 'libegl1' were installed or not, on architectures
> other than x86_64.
> 
> Make base path of the libraries architecture aware to correctly locate
> the libraries on non-x86_64 architectures.
> 
> Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
> ---
>   src/PVE/QemuServer.pm | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index 191ae549..1d740f81 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -1540,7 +1540,15 @@ sub print_vga_device {
>       }
>   
>       if ($vga->{type} eq 'virtio-gl') {
> -        my $base = '/usr/lib/x86_64-linux-gnu/lib';
> +        my $base;
> +        if ($arch eq 'x86_64') {
> +            $base = '/usr/lib/x86_64-linux-gnu/lib';
> +        } elsif ($arch eq 'aarch64') {
> +            $base = '/usr/lib/aarch64-linux-gnu/lib';
> +        } else {
> +            die "unsupported architecture $arch for '$vga->{type}'\n";
> +        }
> +

i think this is wrong because 'arch' is the guest architecture, not the
host one, but we need the library in the hosts context

so doing

my $host_arch = PVE::QemuServer::Helpers::get_host_arch();

and using that would be better IMO

also, we could probably simply interpolate that:

my $base = "/usr/lib/${host_arch}-lnux-gnu/lib";


(if that does not work because the arch string is not equivalent
for the dirs, we could have a map:

my $libs_map = {
'x86_64' => '/usr/lib/x86_64-linux-gnu/lib',
...
};

and then do:

my $base = $libs_map->{$host_arch} // die "unsupported..."

(note that the snippets are just examples and untested)

>           die "missing libraries for '$vga->{type}' detected! Please install 'libgl1' and 'libegl1'\n"
>               if !-e "${base}EGL.so.1" || !-e "${base}GL.so.1";
>