public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-network 1/1] sdn: fix comparison of pending configuration values
Date: Tue, 11 Feb 2025 21:27:07 +0100	[thread overview]
Message-ID: <8bed9174-16c4-4bb7-bae3-1c11084325af@proxmox.com> (raw)
In-Reply-To: <20250207134037.102301-1-s.hanreich@proxmox.com>

Am 07.02.25 um 14:40 schrieb Stefan Hanreich:
> The conditional assignment caused falsy values to be converted to
> undef when comparing them. This led to the behavior that configuration
> values that are interpreted by perl as falsy would get wrongly
> compared and always show up as pending changes.
> 
> As an example the 'bgp-multipath-as-path-relax' or 'ebgp' keys of the
> bgp controller configuration are booleans and get stored as 0 in the
> controller configuration when they're turned off. They always showed
> up as a pending change, because of the behavior described above.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  src/PVE/Network/SDN.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!

btw., doing a declaration behind post-if this is way worse, as with that
the variable will retain the value from the last time the post-if evaluated
to true, it's undef only until then.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-02-11 20:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 13:40 [pve-devel] " Stefan Hanreich
2025-02-11 20:27 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bed9174-16c4-4bb7-bae3-1c11084325af@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal