From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES v2 storage/manager] fix #3580: make preallocation mode selectable for qcow2 and raw images
Date: Thu, 7 Oct 2021 14:47:01 +0200 [thread overview]
Message-ID: <8b4f98d4-c243-e032-5e91-81b522af8c05@proxmox.com> (raw)
In-Reply-To: <20210928130711.4033669-1-l.stechauner@proxmox.com>
Series looks good to me, except for a small nit.
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Am 28.09.21 um 15:07 schrieb Lorenz Stechauner:
> changes to v1:
> * adjusted preallocation api description
> * moved sub preallocation_cmd_option above `# Storage implementation`
> * updated PreallocationSelector to work with `default`
> * reworked placement of Prealloc.Selector in Base.js
>
> pve-storage
> Lorenz Stechauner (1):
> fix #3580: plugins: make preallocation mode selectable for qcow2 and
> raw images
>
> PVE/Storage/BTRFSPlugin.pm | 1 +
> PVE/Storage/CIFSPlugin.pm | 1 +
> PVE/Storage/DirPlugin.pm | 1 +
> PVE/Storage/GlusterfsPlugin.pm | 4 ++-
> PVE/Storage/NFSPlugin.pm | 1 +
> PVE/Storage/Plugin.pm | 48 +++++++++++++++++++++++++++++++++-
> 6 files changed, 54 insertions(+), 2 deletions(-)
>
>
> pve-manager:
> Lorenz Stechauner (2):
> ui: add PreallocationSelector
> fix 3850: ui: storage: using PreallocationSelector for file based
> storage types
>
> www/manager6/Makefile | 1 +
> www/manager6/controller/StorageEdit.js | 6 ++++++
> www/manager6/form/PreallocationSelector.js | 11 +++++++++++
> www/manager6/storage/Base.js | 18 ++++++++++++++++++
> www/manager6/storage/NFSEdit.js | 2 +-
> 5 files changed, 37 insertions(+), 1 deletion(-)
> create mode 100644 www/manager6/form/PreallocationSelector.js
>
prev parent reply other threads:[~2021-10-07 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 13:07 Lorenz Stechauner
2021-09-28 13:07 ` [pve-devel] [PATCH v2 storage 1/1] fix #3580: plugins: " Lorenz Stechauner
2021-10-07 12:44 ` Fabian Ebner
2021-09-28 13:07 ` [pve-devel] [PATCH v2 manager 1/2] ui: add PreallocationSelector Lorenz Stechauner
2021-09-28 13:07 ` [pve-devel] [PATCH v2 manager 2/2] fix 3850: ui: storage: using PreallocationSelector for file based storage types Lorenz Stechauner
2021-10-07 12:45 ` Fabian Ebner
2021-10-07 12:47 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4f98d4-c243-e032-5e91-81b522af8c05@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox