From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
"aderumier@odiso.com" <aderumier@odiso.com>,
"f.ebner@proxmox.com" <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] Fix: cpu hotplug feature can't be changed online
Date: Mon, 23 Oct 2023 21:51:22 +0000 [thread overview]
Message-ID: <8b4319cdd09cacf13b089206c1d34995aa66205d.camel@groupe-cyllene.com> (raw)
In-Reply-To: <1a8ae488-7f5e-4cf3-b63c-d7ba384c98a7@proxmox.com>
Am 10.10.23 um 17:37 schrieb Alexandre Derumier:
> The cpus are passed as devices with specific id only when cpu hotplug
> is enable
> at start.
> We can't enable/disable it online or vcpu hotplug api will thrown
> errors
> not finding core id.
>>When removing cores after enabling the option this is true, but I can
>>1. start a VM without CPU hotplug and fewer than max vCPUs
>>2. enable CPU hotplug
>>3. add more cores
>>And doing the disable of the option online also doesn't seem
>>problematic
>>at a first glance. So I thought this would technically be a breaking
>>change.
Note that is also breaking unplug of cores present before enable
hotplug
>>1. start a VM without CPU hotplug and fewer than max vCPUs
>>2. enable CPU hotplug
>>3. remove cores
(But yes, the more important is migration breaking)
next prev parent reply other threads:[~2023-10-23 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 15:37 Alexandre Derumier
2023-10-11 12:30 ` Fiona Ebner
2023-10-23 21:51 ` DERUMIER, Alexandre [this message]
2023-10-24 9:47 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4319cdd09cacf13b089206c1d34995aa66205d.camel@groupe-cyllene.com \
--to=alexandre.derumier@groupe-cyllene.com \
--cc=aderumier@odiso.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox