[pve-devel] [PATCH widget-toolkit] form: combo grid: fix selection after filtering

[pve-devel] [PATCH widget-toolkit] form: combo grid: fix selection after filtering

[Dominik Csapak]

firing 'refresh' in 'clearLocalFilter' was wrong, since that triggers
too often, for example when selecting an entry (since the field lost
focus). This lead to the picker refreshing and not registering the
click and thus not selecting the desired entry.

Instead refresh the view when we really need it: when the picker is shown.
The filter is already gone, but the picker grid does not know this yet,
so we fire the event then.

Fixes: 7e47328 ("Combogrid: clear filter on blur")

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/form/ComboGrid.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js
index 3ee0238..4cb79d0 100644
--- a/src/form/ComboGrid.js
+++ b/src/form/ComboGrid.js
@@ -300,6 +300,7 @@ Ext.define('Proxmox.form.ComboGrid', {
 	//
 	// we save the minheight to reset it after the load
 	picker.on('show', function() {
+	    me.store.fireEvent('refresh');
 	    if (me.enableLoadMask) {
 		me.savedMinHeight = picker.getMinHeight();
 		picker.setMinHeight(100);
@@ -324,7 +325,6 @@ Ext.define('Proxmox.form.ComboGrid', {
 	    me.store.removeFilter(me.queryFilter, true);
 	    me.queryFilter = null;
 	    me.changingFilters = false;
-	    me.store.fireEvent('refresh');
 	}
     },
 
-- 
2.30.2

[pve-devel] applied: [PATCH widget-toolkit] form: combo grid: fix selection after filtering

[Thomas Lamprecht]

On 28.03.22 15:53, Dominik Csapak wrote:
> firing 'refresh' in 'clearLocalFilter' was wrong, since that triggers
> too often, for example when selecting an entry (since the field lost
> focus). This lead to the picker refreshing and not registering the
> click and thus not selecting the desired entry.
> 
> Instead refresh the view when we really need it: when the picker is shown.
> The filter is already gone, but the picker grid does not know this yet,
> so we fire the event then.
> 
> Fixes: 7e47328 ("Combogrid: clear filter on blur")
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/form/ComboGrid.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!