From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit] form: combo grid: fix selection after filtering
Date: Tue, 29 Mar 2022 17:52:35 +0200 [thread overview]
Message-ID: <8b30b0f8-e785-b221-c8f6-dd1e8ee3451b@proxmox.com> (raw)
In-Reply-To: <20220328135345.1055583-1-d.csapak@proxmox.com>
On 28.03.22 15:53, Dominik Csapak wrote:
> firing 'refresh' in 'clearLocalFilter' was wrong, since that triggers
> too often, for example when selecting an entry (since the field lost
> focus). This lead to the picker refreshing and not registering the
> click and thus not selecting the desired entry.
>
> Instead refresh the view when we really need it: when the picker is shown.
> The filter is already gone, but the picker grid does not know this yet,
> so we fire the event then.
>
> Fixes: 7e47328 ("Combogrid: clear filter on blur")
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/form/ComboGrid.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-03-29 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 13:53 [pve-devel] " Dominik Csapak
2022-03-29 15:52 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b30b0f8-e785-b221-c8f6-dd1e8ee3451b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox