Re: [pve-devel] [PATCH v3 container 3/5]: fix #3069: vzdump: add 'pbs-entries-max' parameter

[Fiona Ebner <f.ebner@proxmox.com>]

Am 27.07.23 um 10:37 schrieb Alexander Zeidler:
> configuring pbs-entries-max can avoid failing backups due to a high
> amount of files in folders where a folder exclusion is not possible
> 
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm
> index 5783ffa..a2bcdd7 100644
> --- a/src/PVE/VZDump/LXC.pm
> +++ b/src/PVE/VZDump/LXC.pm
> @@ -395,6 +395,12 @@ sub archive {
>  	push @$param, '--backup-id', $vmid;
>  	push @$param, '--backup-time', $task->{backup_time};
>  
> +	if (my $entries_max = $opts->{"performance"}->{"pbs-entries-max"}) {
> +	    push $param->@*, '--entries-max', $entries_max;
> +	    $self->loginfo("set max number of entries in memory for file-based backups to "
> +		."$entries_max");

Style nit: not entirely sure if this is allowed by our style guide
(because of the argument going over two lines but not separated from the
parentheses) or if it should be one of

>             $self->loginfo(
>                 "set max number of entries in memory for file-based backups to $entries_max");

>             $self->loginfo(
>                 "set max number of entries in memory for file-based backups to $entries_max"
>             );