From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: firewall: rule: maxlength for source and dest
Date: Thu, 22 Apr 2021 21:34:49 +0200 [thread overview]
Message-ID: <8a308b16-ab0b-a7d2-05be-054a52309077@proxmox.com> (raw)
In-Reply-To: <20210422123010.14006-2-a.lauterer@proxmox.com>
On 22.04.21 14:30, Aaron Lauterer wrote:
> Limiting the length of the source and dest paramters helps to avoid
> problems with iptables-restore which would not apply a rule if a
> parameter is larger than the parameter buffer (1024)[0]. As the API is
> already limiting this, we should also reflect that in the GUI and give
> people a hint that IP sets are most likely the better approach.
>
> [0] http://git.netfilter.org/iptables/tree/iptables/xshared.c?h=v1.8.7#n469
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> This one "needs" the firewall patch 'fix #967: source: dest: limit length'
>
> As always when it comes to messages, someone might have a better idea
> how to phrase the maxLengthText.
>
good enough for me :)
> www/manager6/grid/FirewallRules.js | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2021-04-22 19:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 12:30 [pve-devel] [PATCH firewall] fix #967: source: dest: limit length Aaron Lauterer
2021-04-22 12:30 ` [pve-devel] [PATCH manager] ui: firewall: rule: maxlength for source and dest Aaron Lauterer
2021-04-22 19:34 ` Thomas Lamprecht [this message]
2021-04-22 17:03 ` [pve-devel] applied: [PATCH firewall] fix #967: source: dest: limit length Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a308b16-ab0b-a7d2-05be-054a52309077@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox