From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, s.reiter@proxmox.com
Subject: Re: [pve-devel] [PATCH manager 4/4] ui: snapshot: show task viewer for progress log
Date: Fri, 5 Feb 2021 09:42:03 +0100 [thread overview]
Message-ID: <89d3a6c0-23f8-eb59-9bf4-c33d693d118a@proxmox.com> (raw)
In-Reply-To: <20210204125224.25059-4-s.reiter@proxmox.com>
Am 04.02.21 um 13:52 schrieb Stefan Reiter:
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
> www/manager6/window/Snapshot.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/window/Snapshot.js b/www/manager6/window/Snapshot.js
> index 2fa97041..a5fddd0f 100644
> --- a/www/manager6/window/Snapshot.js
> +++ b/www/manager6/window/Snapshot.js
> @@ -139,7 +139,8 @@ Ext.define('PVE.window.Snapshot', {
> if (me.isCreate) {
> subject = (me.type === 'qemu' ? 'VM' : 'CT') + me.vmid + ' ' + gettext('Snapshot');
> me.method = 'POST';
> - me.showProgress = true;
> + me.showProgress = !me.running;
> + me.showTaskViewer = me.running;
Nit: Should this be based on the 'vmstate' parameter instead? The task
log for a running VM without including the state contains the same lines
as for a shut down VM (those about the drives), so it feels a little
inconsistent to show it in one situation, but not in the other.
> } else {
> subject = `${gettext('Snapshot')} ${me.snapname}`;
> me.url += `/${me.snapname}/config`;
>
next prev parent reply other threads:[~2021-02-05 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 12:52 [pve-devel] [PATCH qemu-server 1/4] vzdump: use renderers from Tools instead of duplicating code Stefan Reiter
2021-02-04 12:52 ` [pve-devel] [PATCH qemu-server 2/4] savevm: periodically print progress Stefan Reiter
2021-02-05 13:21 ` Thomas Lamprecht
2021-02-04 12:52 ` [pve-devel] [PATCH qemu-server 3/4] savevm: show information about drives during snapshot Stefan Reiter
2021-02-04 13:51 ` [pve-devel] [PATCH v2 " Stefan Reiter
2021-02-04 12:52 ` [pve-devel] [PATCH manager 4/4] ui: snapshot: show task viewer for progress log Stefan Reiter
2021-02-05 8:42 ` Fabian Ebner [this message]
2021-02-05 13:05 ` [pve-devel] [PATCH qemu-server 1/4] vzdump: use renderers from Tools instead of duplicating code Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89d3a6c0-23f8-eb59-9bf4-c33d693d118a@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox