From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 2/3] headerbar: show shortcut for search in emptyText
Date: Fri, 21 Jul 2023 15:31:21 +0200 [thread overview]
Message-ID: <89b8322f-ee76-4574-941a-4c86d4f42aac@proxmox.com> (raw)
In-Reply-To: <20230721093910.254158-2-l.wagner@proxmox.com>
On 21/07/2023 11:39, Lukas Wagner wrote:
> The shortcut is not really documented anywhere, so I think it make it a
> bit more obvious to the user.
style not: commit message should wrap text at 70 character columns.
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> www/manager6/form/GlobalSearchField.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/form/GlobalSearchField.js b/www/manager6/form/GlobalSearchField.js
> index c009ac8b..8e5e13c0 100644
> --- a/www/manager6/form/GlobalSearchField.js
> +++ b/www/manager6/form/GlobalSearchField.js
> @@ -8,7 +8,7 @@ Ext.define('PVE.form.GlobalSearchField', {
> extend: 'Ext.form.field.Text',
> alias: 'widget.pveGlobalSearchField',
>
> - emptyText: gettext('Search'),
> + emptyText: gettext('Search (Ctrl-Shift-F)'),
not true for MacOS though, maybe check navigator.platform for /mac/i and
depending on that use CTRL or ⌘
Semi-related, is the aria-keyshortcuts attribute actually set here?
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-keyshortcuts
next prev parent reply other threads:[~2023-07-21 13:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 9:39 [pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG Lukas Wagner
2023-07-21 9:39 ` [pve-devel] [PATCH manager 2/3] headerbar: show shortcut for search in emptyText Lukas Wagner
2023-07-21 13:31 ` Thomas Lamprecht [this message]
2023-07-21 14:04 ` Lukas Wagner
2023-07-21 9:39 ` [pve-devel] [PATCH manager 3/3] headerbar: center search box, make it adapt to the width of the browser Lukas Wagner
2023-07-21 13:54 ` Thomas Lamprecht
2023-07-21 14:54 ` Lukas Wagner
2023-07-21 14:04 ` [pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG Thomas Lamprecht
2023-07-24 8:25 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89b8322f-ee76-4574-941a-4c86d4f42aac@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox