From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied-series: [PATCH ha-manager 1/2] fix #4984: recompute online usage: add service usage to migration target only if online
Date: Mon, 9 Oct 2023 08:45:06 +0200 [thread overview]
Message-ID: <899c8911-3f07-28d8-2e28-b035e5b17e21@proxmox.com> (raw)
In-Reply-To: <08051548-fddc-4fa5-984e-fc3e34469328@proxmox.com>
Am 06.10.23 um 18:10 schrieb Thomas Lamprecht:
> Am 05/10/2023 um 16:05 schrieb Fiona Ebner:
>> Otherwise, when using the 'basic' plugin, this would lead to
>> autovivification of the $target node in the Perl hash tracking the
>> usage and it would wrongly be considered online when selecting the
>> recovery node.
>>
>> The 'static' plugin was not affected, because it would check and warn
>> before adding usage to a node that was not registered with add_node()
>> first. Doing the same in the 'basic' plugin will be done by another
>> patch.
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>> src/PVE/HA/Manager.pm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>>
>
> applied both patches with slightly rewording/shortening the commit message
> subject, thanks!
Does it make sense for stable-7 too or is this too much of an edge case?
The bug report was with Proxmox VE 7.
prev parent reply other threads:[~2023-10-09 6:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 14:05 [pve-devel] " Fiona Ebner
2023-10-05 14:05 ` [pve-devel] [PATCH ha-manager 2/2] usage: basic: avoid node autovivification when adding service usage Fiona Ebner
2023-10-05 14:13 ` [pve-devel] [PATCH ha-manager 1/2] fix #4984: recompute online usage: add service usage to migration target only if online Fiona Ebner
2023-10-06 16:10 ` [pve-devel] applied-series: " Thomas Lamprecht
2023-10-09 6:45 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=899c8911-3f07-28d8-2e28-b035e5b17e21@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox