public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH-SERIES v2 manager] stricter storage rules for migration
Date: Mon, 21 Jun 2021 17:18:20 +0200	[thread overview]
Message-ID: <8972feac-f6a3-02df-09b0-caf9cf3dfadd@proxmox.com> (raw)
In-Reply-To: <20210621143140.2022-1-f.ebner@proxmox.com>

On 21.06.21 16:31, Fabian Ebner wrote:
> Changes from v1:
>     * dropped already applied patches
>     * rebased
>     * adapted/improved messages
> 
> Fabian Ebner (2):
>   pve6to7: add check for guest images on misconfigured storages
>   pve6to7: check for misconfigured content type 'none'
> 
>  PVE/CLI/pve6to7.pm | 50 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 


applied, thanks! I adapted the output a bit to list them newline-separated, was a bit
clearer here, in my case.

And maybe we want to further filter those by the ones actually found in VM configs?

As else it may be a false-positive, e.g., one may have added the same storage twice,
which can be OK as long as both entries do not share any content-type, as then there
should be no locking issue or other issues stemming from our base assumption that one
storage is there only once (a use case could be priv. separation).

It at least feels a bit odd to me to get warnings for disks which's VMID is neither a
guest nor a configured anywhere in the cluster.




  parent reply	other threads:[~2021-06-21 15:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 14:31 [pve-devel] " Fabian Ebner
2021-06-21 14:31 ` [pve-devel] [PATCH v2 manager 1/2] pve6to7: add check for guest images on misconfigured storages Fabian Ebner
2021-06-21 14:31 ` [pve-devel] [PATCH v2 manager 2/2] pve6to7: check for misconfigured content type 'none' Fabian Ebner
2021-06-21 15:18 ` Thomas Lamprecht [this message]
2021-06-24  7:43   ` [pve-devel] applied-series: [PATCH-SERIES v2 manager] stricter storage rules for migration Fabian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8972feac-f6a3-02df-09b0-caf9cf3dfadd@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal