Re: [pve-devel] [PATCH v2 manager 2/4] api: backup: add 'pbs-entries-max' to permission check & config

[Fiona Ebner <f.ebner@proxmox.com>]

Am 15.06.23 um 16:14 schrieb Alexander Zeidler:
> configuring pbs-entries-max can avoid failing backups due to a high
> amount of files in folders where a folder exclusion is not possible
> 
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> Changes from v1:
> Add 'pbs-entries-max' according to the new shortened permission check
> 
>  PVE/API2/Backup.pm  | 2 +-
>  configs/vzdump.conf | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
> index 70753c2e..206ef1d9 100644
> --- a/PVE/API2/Backup.pm
> +++ b/PVE/API2/Backup.pm
> @@ -49,7 +49,7 @@ sub assert_param_permission_common {
>  	raise_param_exc({ $key => "Only root may set this option."}) if exists $param->{$key};
>      }
>  
> -    if (grep { defined($param->{$_}) } qw(bwlimit ionice performance)) {
> +    if (grep { defined($param->{$_}) } qw(bwlimit ionice performance pbs-entries-max)) {

This is not needed, as it's a sub-option of performance now.

>  	$rpcenv->check($user, "/", [ 'Sys.Modify' ]);
>      }
>  }
> diff --git a/configs/vzdump.conf b/configs/vzdump.conf
> index 2ea09ae0..2fbf3999 100644
> --- a/configs/vzdump.conf
> +++ b/configs/vzdump.conf
> @@ -16,3 +16,4 @@
>  #exclude-path: PATHLIST
>  #pigz: N
>  #notes-template: {{guestname}}
> +#pbs-entries-max: N

It's not a lone-standing option, but part of performance.