From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH proxmox 1/2] notify: webhook: gotify: set Content-Length header
Date: Wed, 26 Mar 2025 11:20:26 +0100 [thread overview]
Message-ID: <88db9d7d-843e-47dc-8f62-44054a3a0824@proxmox.com> (raw)
In-Reply-To: <3230a5ae-a5e7-42c7-9cc4-587fe194e29f@proxmox.com>
On 2025-03-26 11:11, Thomas Lamprecht wrote:
> Am 26.03.25 um 10:54 schrieb Lukas Wagner:
>> On 2025-03-25 19:41, Thomas Lamprecht wrote:
>>> FWIW, as it was already encoded in the commit message for posterity I'd
>>> have been fine with the comment being a bit shorter, e.g., the link to
>>> the RFC and the last line, but it did not bother me to care amending the
>>> patch and it's not a clear-cut, or at least subjective, so just a nit.
>>
>> The brief quote from the RFC gives good context on *why* the change should be done
>> in a self-contained way without having to go to the RFC text and search for the correct
>> paragraph. IMO it definitely makes sense to have it in the commit message.
>
> Yes, that's why I explicitly state that it makes sense in the *commit*
> message, but that doing that is enough compared to also having the full
> thing permanently as *comment* in the code like you did...
> Because if we would do that for all implementation details the code
> will get unreadable quickly.
>
Apparently my brain failed to parse and distinguish "commit" and "comment" successfully.
Sorry for the confusion.
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-03-26 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 9:56 [pve-devel] " Lukas Wagner
2025-03-21 9:57 ` [pve-devel] [PATCH proxmox 2/2] notify: gotify: use constant from http crate for 'Authorization' header Lukas Wagner
2025-03-25 18:41 ` [pve-devel] applied: [PATCH proxmox 1/2] notify: webhook: gotify: set Content-Length header Thomas Lamprecht
2025-03-26 9:54 ` Lukas Wagner
2025-03-26 10:11 ` Thomas Lamprecht
2025-03-26 10:20 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88db9d7d-843e-47dc-8f62-44054a3a0824@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal