From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH manager 2/3] ui: SystemEdit: promote advanced settings to normal
Date: Wed, 3 Nov 2021 14:02:54 +0100 [thread overview]
Message-ID: <88b0c551-3735-6be2-fa09-1fa6cbafe4f5@proxmox.com> (raw)
In-Reply-To: <7e6e5b21-e153-e847-a579-3a38610c8b25@proxmox.com>
On 10/21/21 13:51, Thomas Lamprecht wrote:
> On 11.10.21 14:55, Stefan Reiter wrote:
>> and reorder the panel a bit, as otherwise I found it *very* cluttered.
>>
>> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
>> ---
>> www/manager6/qemu/SystemEdit.js | 50 +++++++++++++++------------------
>> 1 file changed, 22 insertions(+), 28 deletions(-)
>>
>>
>
> applied, thanks!
>
> But I still find that the visual separation of the hr + space of the advanced section
> provided some UX improvement, felt less crowded that way.
>
> Maybe we can place that in a box+<legend>Firmware</legend>
could work, would have to test
> thingy or at least have a
> Label-only element with "Firmware" in columnt 1 and an empty element in column 2 to
> somewhat replicate that visual grouping?
>
we do it like that already for the sync edit options in the realmedit,
so maybe we should stay consistent here and use the same style?
if you want, i can send a patch for this
next prev parent reply other threads:[~2021-11-03 13:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 12:55 [pve-devel] [PATCH 0/3] Windows 11 OS type and UI improvements Stefan Reiter
2021-10-11 12:55 ` [pve-devel] [PATCH qemu-server 1/3] ostype: support Windows 11/Server 2022 Stefan Reiter
2021-10-18 7:54 ` [pve-devel] applied: " Thomas Lamprecht
2021-10-18 8:00 ` Thomas Lamprecht
2021-10-11 12:55 ` [pve-devel] [PATCH manager 2/3] ui: SystemEdit: promote advanced settings to normal Stefan Reiter
2021-10-21 11:51 ` [pve-devel] applied: " Thomas Lamprecht
2021-11-03 13:02 ` Dominik Csapak [this message]
2021-11-03 13:26 ` Thomas Lamprecht
2021-10-11 12:55 ` [pve-devel] [PATCH manager 3/3] ui: add 'win11' ostype and set defaults in wizard Stefan Reiter
2021-10-18 5:57 ` DERUMIER, Alexandre
2021-10-18 7:10 ` Thomas Lamprecht
2021-10-19 9:19 ` DERUMIER, Alexandre
2021-10-21 11:52 ` [pve-devel] applied: " Thomas Lamprecht
2021-10-12 13:51 ` [pve-devel] [PATCH 0/3] Windows 11 OS type and UI improvements Aaron Lauterer
2021-10-12 15:24 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88b0c551-3735-6be2-fa09-1fa6cbafe4f5@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox