public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Mira Limbeck <m.limbeck@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH 1/8 container] cloudinit: introduce config parameters
Date: Thu, 13 Feb 2025 11:18:36 +0100	[thread overview]
Message-ID: <889deaba-3bf3-4ff4-9283-df69d3cd61c8@proxmox.com> (raw)
In-Reply-To: <03866a14-f5a5-4233-94b0-203ea1e7515e@proxmox.com>

On 2/13/25 11:10, Fiona Ebner wrote:
> Am 10.02.25 um 13:07 schrieb Daniel Herzig:
>> From: Leo Nunner <l.nunner@proxmox.com>
>>
>> Introduce configuration parameters for cloud-init. Like with VMs, it's
>> possible to specify:
>>     - user
>>     - password
>>     - ssh keys
>>     - enable/disable updates on first boot
>>
>> It's also possible to pass through custom config files for the user and
>> vendor settings. We don't allow configuring the network through
>> cloud-init, since it will clash with whatever configuration we already
>> did for the container.
> 
> Unfortunately, Leo didn't write why configuring 'meta' for cicustom is
> not allowed...
Maybe because you can configure network interfaces via metadata as well?
https://cloudinit.readthedocs.io/en/latest/reference/datasources/nocloud.html#example-meta-data

We don't do that in any of our code, but custom configs circumvent that.

> 
>> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
>> index 5cc37f7..e3ed93b 100644
>> --- a/src/PVE/LXC/Config.pm
>> +++ b/src/PVE/LXC/Config.pm
>> @@ -450,6 +450,63 @@ my $features_desc = {
>>      },
>>  };
>>  
>> +my $cicustom_fmt = {
>> +    user => {
>> +	type => 'string',
>> +	optional => 1,
>> +	description => 'To pass a custom file containing all user data to the container via cloud-init.',
>> +	format => 'pve-volume-id',
>> +	format_description => 'volume',
>> +    },
>> +    vendor => {
>> +	type => 'string',
>> +	optional => 1,
>> +	description => 'To pass a custom file containing all vendor data to the container via cloud-init.',
>> +	format => 'pve-volume-id',
>> +	format_description => 'volume',
>> +    },
> 
> ...i.e. it's missing here. This might be an oversight, because the doc
> patch mentions it in an example command: 'pct set 9000 --cicustom
> "user=<volume>,meta=<volume>"'
> 
>> +};
>> +PVE::JSONSchema::register_format('pve-pct-cicustom', $cicustom_fmt);
>> +
>> +my $confdesc_cloudinit = {
>> +    cienable => {
>> +	optional => 1,
>> +	type => 'boolean',
>> +	description => "cloud-init: provide cloud-init configuration to container.",
> 
> Missing the default.
> 
>> +    },
>> +    ciuser => {
>> +	optional => 1,
>> +	type => 'string',
>> +	description => "cloud-init: User name to change ssh keys and password for instead of the"
>> +	    ." image's configured default user.",
>> +    },
>> +    cipassword => {
>> +	optional => 1,
>> +	type => 'string',
>> +	description => 'cloud-init: Password to assign the user. Using this is generally not'
>> +	    .' recommended. Use ssh keys instead. Also note that older cloud-init versions do not'
>> +	    .' support hashed passwords.',
>> +    },
>> +    ciupgrade => {
>> +	optional => 1,
>> +	type => 'boolean',
>> +	description => 'cloud-init: do an automatic package update on boot.'
> 
> Missing the default.
> 
>> +    },
>> +    cicustom => {
>> +	optional => 1,
>> +	type => 'string',
>> +	description => 'cloud-init: Specify custom files to replace the automatically generated'
>> +	    .' ones at start.',
>> +	format => 'pve-pct-cicustom',
>> +    },
>> +    sshkeys => {
>> +	optional => 1,
>> +	type => 'string',
>> +	format => 'urlencoded',
>> +	description => "cloud-init: Setup public SSH keys (one key per line, OpenSSH format).",
>> +    },
>> +};
>> +
>>  my $confdesc = {
>>      lock => {
>>  	optional => 1,
>> @@ -622,6 +679,10 @@ my $confdesc = {
>>      },
>>  };
>>  
>> +foreach my $key (keys %$confdesc_cloudinit) {
> 
> Style nit: use "for"
> 
>> +    $confdesc->{$key} = $confdesc_cloudinit->{$key};
>> +}
>> +
>>  my $valid_lxc_conf_keys = {
>>      'lxc.apparmor.profile' => 1,
>>      'lxc.apparmor.allow_incomplete' => 1,
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-02-13 10:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 12:07 [pve-devel] [PATCH 0/8 container/manager/docs] fix #4686: Cloudinit support for LXC Daniel Herzig
2025-02-10 12:07 ` [pve-devel] [PATCH 1/8 container] cloudinit: introduce config parameters Daniel Herzig
2025-02-13 10:10   ` Fiona Ebner
2025-02-13 10:18     ` Mira Limbeck [this message]
2025-02-13 10:22       ` Fiona Ebner
2025-02-13 10:23   ` Fiona Ebner
2025-02-13 15:05     ` Daniel Herzig
2025-02-13 12:15   ` Fiona Ebner
2025-02-10 12:07 ` [pve-devel] [PATCH 2/8 container] cloudinit: basic implementation Daniel Herzig
2025-02-13 11:01   ` Fiona Ebner
2025-02-13 11:29     ` Mira Limbeck
2025-02-13 12:02       ` Fiona Ebner
2025-02-13 15:09       ` Daniel Herzig
2025-02-13 12:06     ` Fiona Ebner
2025-02-10 12:07 ` [pve-devel] [PATCH 3/8 container] cloudinit: add dump command to pct Daniel Herzig
2025-02-13 12:00   ` Fiona Ebner
2025-02-10 12:07 ` [pve-devel] [PATCH 4/8 container] cloudinit: add function dumping options for docs Daniel Herzig
2025-02-10 12:07 ` [pve-devel] [PATCH 5/8 manager] cloudinit: rename qemu cloudinit panel Daniel Herzig
2025-02-10 12:07 ` [pve-devel] [PATCH 6/8 manager] cloudinit: introduce panel for LXCs Daniel Herzig
2025-02-10 12:07 ` [pve-devel] [PATCH 7/8 docs] pct: add script to generate cloudinit options Daniel Herzig
2025-02-13  9:52   ` Fiona Ebner
2025-02-10 12:07 ` [pve-devel] [PATCH 8/8 docs] pct: document cloudinit for LXC Daniel Herzig
2025-02-12 15:46   ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=889deaba-3bf3-4ff4-9283-df69d3cd61c8@proxmox.com \
    --to=m.limbeck@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal