From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] build: run shellcheck as part of `test` step
Date: Fri, 22 Mar 2024 11:39:54 +0100 [thread overview]
Message-ID: <887a29a4-cc91-4f85-9fcc-1897799cd1ff@proxmox.com> (raw)
In-Reply-To: <20240315102345.458366-2-c.heiss@proxmox.com>
On 15/03/2024 11:23, Christoph Heiss wrote:
> Especially unconfigured.sh is worth checking consistently.
>
> Running shellcheck also does not really have any notable impact on build
> time, so no downside there either.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Makefile | 14 +++++++++-----
> debian/control | 1 +
> unconfigured.sh | 3 +++
> xinitrc | 2 ++
> 4 files changed, 15 insertions(+), 5 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2024-03-22 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 10:23 [pve-devel] " Christoph Heiss
2024-03-22 10:39 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=887a29a4-cc91-4f85-9fcc-1897799cd1ff@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox