From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] fix #4289: pbs: wait for backup verification to finish before updating volume attribute
Date: Tue, 10 Jan 2023 14:21:54 +0100 [thread overview]
Message-ID: <887051ff-30e4-2fb7-f2f5-90d6770e05d5@proxmox.com> (raw)
In-Reply-To: <159837ba-f916-7b03-2cab-8e486b38b6bb@proxmox.com>
Am 10.01.23 um 14:06 schrieb Fiona Ebner:
> Am 10.01.23 um 13:44 schrieb Christoph Heiss:
>> On Tue, Jan 10, 2023 at 01:34:14PM +0100, Fiona Ebner wrote:
>>> One way to decide if the current behavior should be used as a fallback
>>> would be to check the protected status after finishing the backup. That
>>> is slightly racy though, because something else could've already changed
>>> the protection between finishing and the check.
>> I'd base it off the decision from above - if the `proxmox-backup-client`
>> version supports setting it directly, use that, otherwise simply fall
>> back.
> It's not just the client, but the server that needs to support it too.
> To make sure that the client/QEMU/etc. support it, we can just have
> pve-manager depend on a recent enough version. For the server, there is
> a /version API endpoint we can query.
For QEMU, we don't want to force specific package versions, so using
package dependency is not good there. Instead, we can use the
'query-proxmox-support' QMP command to see if it's supported. That also
makes the check work for already running VMs.
prev parent reply other threads:[~2023-01-10 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 12:36 [pve-devel] [PATCH manager/storage] fix #4289: " Christoph Heiss
2023-01-02 12:36 ` [pve-devel] [PATCH manager] vzdump: pass logfunc down into storage plugin when " Christoph Heiss
2023-01-02 12:36 ` [pve-devel] [PATCH storage] fix #4289: pbs: wait for backup verification to finish before " Christoph Heiss
2023-01-04 10:50 ` Fiona Ebner
2023-01-10 11:11 ` Christoph Heiss
2023-01-10 12:34 ` Fiona Ebner
2023-01-10 12:44 ` Christoph Heiss
[not found] ` <159837ba-f916-7b03-2cab-8e486b38b6bb@proxmox.com>
2023-01-10 13:21 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=887051ff-30e4-2fb7-f2f5-90d6770e05d5@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox