public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Herzig <d.herzig@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH docs 1/2] pve-storage-lvm: fix rendering of storage features
Date: Thu, 30 Apr 2026 09:50:06 +0200	[thread overview]
Message-ID: <87y0i4opjl.fsf@proxmox.com> (raw)
In-Reply-To: <20260323152128.403083-2-m.sandoval@proxmox.com>

Thanks for this. This gracefully fixes the confusing table.

Reviewed-by: Daniel Herzig <d.herzig@proxmox.com>

Maximiliano Sandoval <m.sandoval@proxmox.com> writes:

> Without this change, the table will be rendered as if it had 1+1+3=5
> columns instead of 6 columns. As a consequence the content of "Content
> types" would be "Linked Clones" instead of "images rootdir".
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  pve-storage-lvm.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pve-storage-lvm.adoc b/pve-storage-lvm.adoc
> index 351749b..767fd7f 100644
> --- a/pve-storage-lvm.adoc
> +++ b/pve-storage-lvm.adoc
> @@ -125,7 +125,7 @@ TIP: You can use the LVM-thin backend for non-shared local storage. It supports
>  snapshots and linked clones.
>  
>  .Storage features for backend `lvm`
> -[width="100%",cols="m,m,3*d",options="header"]
> +[width="100%",cols="m,m,4*d",options="header"]
>  |===============================================================================
>  |Content types  |Image formats  |Shared   |Snapshots |Full Clones |Linked Clones
>  |images rootdir |raw, qcow2     |possible |yes^1^    |yes         |no




  reply	other threads:[~2026-04-30  7:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 15:21 [PATCH docs 0/2] pve-storage-lvm: document qcow2 availability Maximiliano Sandoval
2026-03-23 15:21 ` [PATCH docs 1/2] pve-storage-lvm: fix rendering of storage features Maximiliano Sandoval
2026-04-30  7:50   ` Daniel Herzig [this message]
2026-03-23 15:21 ` [PATCH docs 2/2] pve-storage-lvm: document qcow2 availability Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0i4opjl.fsf@proxmox.com \
    --to=d.herzig@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal