From: Daniel Herzig <d.herzig@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-esxi-import-tools] fix #6347: do not break vm listing on invalid configs
Date: Wed, 23 Apr 2025 17:17:00 +0200 [thread overview]
Message-ID: <87plh2syab.fsf@proxmox.com> (raw)
In-Reply-To: <cb8be5b8-a469-4a12-9a61-851608060dbf@proxmox.com> (Daniel Kral's message of "Wed, 23 Apr 2025 16:45:37 +0200")
Daniel Kral <d.kral@proxmox.com> writes:
> On 4/23/25 16:04, Daniel Herzig wrote:
>>> Oops, I should have prefixed my patch with a "fix" at least, but I've
>>> sent two patches some days ago for this ;):
>>>
>>> https://lore.proxmox.com/pve-devel/20250411150634.253684-1-d.kral@proxmox.com/T/#u
>>>
>> Ha, I missed that one, you were too quick ;)
>> It turned out that the problem was on the specific ESXI-side config
>> (`vm.config` is there on ESXI-6.7.x as well, without it we could not do
>> anything anyway -- `fetch_and_update_vm_data` calls it more than
>> once inherently). But it's `None` for sure if there's an invalid vm config on the ESXI side.
>
> Thanks for the info!
>
> I was wondering why it didn't work for them (in the forum) and have
> only figured that there was something undocumented in the PyVim API
> about when the OptionType is None, but with either patch it should be
> fine now :).
>
I think so too!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-23 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 13:03 Daniel Herzig
2025-04-23 13:28 ` Daniel Kral
2025-04-23 14:04 ` Daniel Herzig
2025-04-23 14:45 ` Daniel Kral
2025-04-23 15:17 ` Daniel Herzig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plh2syab.fsf@proxmox.com \
--to=d.herzig@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal