From: Daniel Herzig <d.herzig@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager] certificate: make sure that any new certificate and key match
Date: Wed, 06 May 2026 13:28:45 +0200 [thread overview]
Message-ID: <87pl384w0i.fsf@proxmox.com> (raw)
In-Reply-To: <20260506110452.166057-1-s.sterz@proxmox.com>
Thanks for this!
I just built, installed and tested the package.
Works perfectly fine, as described in the commit message.
Tested-by: Daniel Herzig <d.herzig@proxmox.com>
Shannon Sterz <s.sterz@proxmox.com> writes:
> previously it was possible to upload and set a key and certificate
> combination, that did not match each other. this lead to confusing
> errors as pveproxy would seemingly start, but not actually serve any
> http connections. in a cluster context this leads to "broken pipe"
> errors when connecting to such a misconfigured node. since this is
> rather confusing, verify that a key and certificate can actually be
> used before setting them as the current certificates by loading them
> into a TLS context.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>
> Notes:
> this came up in the enterprise support and caused quite a bit of
> confusion.
>
> PVE/CertHelpers.pm | 27 +++++++++++++++++++++++++++
next prev parent reply other threads:[~2026-05-06 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 11:04 [PATCH manager] certificate: make sure that any new certificate and key match Shannon Sterz
2026-05-06 11:28 ` Daniel Herzig [this message]
2026-05-06 11:54 ` Thomas Lamprecht
2026-05-06 12:39 ` Shannon Sterz
2026-05-06 12:50 ` Superseded: " Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl384w0i.fsf@proxmox.com \
--to=d.herzig@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox