Re: [pve-devel] [PATCH esxi-import-tools] listvms: exclude VMs without datastore_name from manifest.json.

[Daniel Herzig <d.herzig@proxmox.com>]

Wolfgang Bumiller <w.bumiller@proxmox.com> writes:

>>          for vm in list_vms(connection):
>> +            # skip vms with empty datastore_name
>> +            datastore_name, relative_vmx_path = parse_file_path(
>> +                vm.config.files.vmPathName
>> +            )
>> +            if not datastore_name:
>
> While this works as a stop-gap, I think we should use the example code
> here[1] to test if this is such an embedded(?) vCLS VM, and if it is
> *not* such a VM, print a warning to stderr that we're skipping this VM,
> so that in the future, if VMs magically disappear, we should see log
> messages about this.
>
> [1]
> https://knowledge.broadcom.com/external/article/370219/script-identification-for-embedded-vcls.html

I agree -- above is more of a handbrake-solution. I'll see what I can do
for proper indentification. Thanks a lot for the link, I missed that
there's more focussed identifiers available already.

>
>> +                continue
>>              try:
>>                  fetch_and_update_vm_data(vm, data)
>>              except Exception as err:
>> -- 
>> 2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel