public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Friedrich Weber <f.weber@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] report: add WWN column to lsblk output
Date: Tue, 1 Apr 2025 10:04:53 +0200	[thread overview]
Message-ID: <8744ae16-6185-4430-9d58-a2e8ecf467c5@proxmox.com> (raw)
In-Reply-To: <20250331094135.100410-1-f.weber@proxmox.com>

On 3/31/25 11:41, Friedrich Weber wrote:
> WWNs (WWIDs) are useful information for debugging setups where
> multipath is not (correctly) set up, as the WWN reveals which block
> devices point to the same LUN. The report currently does not provide
> WWNs in such scenarios. There is a symlink for the WWN under
> /dev/disk/by-id/wwn-*, but if there are multiple block devices with
> the same WWN, the symlink just points to one of them.
> 
> Hence, add the WWN column to the lsblk output.
> 
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
>   PVE/Report.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 1ed91c8e..8f53823e 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -117,7 +117,7 @@ my $init_report_cmds = sub {
>   	'block devices' => {
>   	    order => 80,
>   	    cmds => [
> -		'lsblk --ascii -M -o +HOTPLUG,ROTA,PHY-SEC,FSTYPE,MODEL,TRAN',
> +		'lsblk --ascii -M -o +HOTPLUG,ROTA,PHY-SEC,FSTYPE,MODEL,TRAN,WWN',
>   		'ls -l /dev/disk/by-*/',
>   		'iscsiadm -m node',
>   		'iscsiadm -m session',

Tested this by adding SCSI, IDE, and SATA hard disks to a VM and 
manually setting a WWN via qm set. I noticed that the output of lsblk 
does only show a WWN for the SCSI disk, but not for the others. smartctl 
-i does return a WWN for the SATA disk and scsi_id also seems to 
recognize the manually set value. I think it could make sense to add a 
note to the documentation regarding the limitations of the lsblk output 
in this regard?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-04-01  8:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31  9:41 Friedrich Weber
2025-04-01  8:04 ` Michael Köppl [this message]
2025-04-01  9:56   ` Thomas Lamprecht
2025-04-01  9:56 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8744ae16-6185-4430-9d58-a2e8ecf467c5@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=f.weber@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal