public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	"DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>,
	"f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] api2: network: anybridge: re-add regular bridges
Date: Wed, 27 Apr 2022 15:15:29 +0200	[thread overview]
Message-ID: <8713b0f2-b71e-f7eb-c651-8336f9c9e94d@proxmox.com> (raw)
In-Reply-To: <27858f5825dd14d370504c67bf877dc6d53a4bfc.camel@groupe-cyllene.com>

On 27.04.22 14:32, DERUMIER, Alexandre wrote:
> I didn' see, but Thomas have reworked it:
> https://git.proxmox.com/?p=pve-manager.git;a=commit;h=640c0b26891c408d0456c355b3724c1be18cc75f
> 
> and the behaviour seem to be different:

argh, sorry, the can_access_vnet sub should also had an:

return 1 if !($have_sdn && $param->{type} eq 'any_bridge');

to make it equivalent with what you had before... :/




      parent reply	other threads:[~2022-04-27 13:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 11:36 Fabian Grünbichler
2022-04-27 11:56 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-27 12:32 ` [pve-devel] " DERUMIER, Alexandre
2022-04-27 12:45   ` Fabian Grünbichler
2022-04-27 13:04     ` DERUMIER, Alexandre
2022-04-27 13:15   ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8713b0f2-b71e-f7eb-c651-8336f9c9e94d@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=Alexandre.DERUMIER@groupe-cyllene.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal