public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: RBDStorage: add field for RBD namespace
Date: Fri, 16 Apr 2021 17:48:38 +0200	[thread overview]
Message-ID: <86b079a3-9bb3-21ae-2dda-95069e5e7a4c@proxmox.com> (raw)
In-Reply-To: <70e563f9-660f-8e70-f366-a73e3c55837f@proxmox.com>

On 16.04.21 17:39, Aaron Lauterer wrote:
> Thx for the feedback and yep, I forgot to run the linter...
> 

there's to much noise still in it for this repo, so totally understandable.

> Anything against doing it via `rbd -p pool namespace ls`? AFAICT there is no
> lightweight command to list namespaces via `rados`. Only thing I found was
> listing all objects in the pool and fetching used namespaces from that
> output: `rados -p rbd ls --format json` but that is an expensive operation.

I mean, this is not a frequent operation, so we could ignore the overhead of
fork + exec. So yes, I would accept that. If we find something more efficient 
it could always get replaced by that transparently any way.

> One thing though that we should consider: so far adding an external RBD
> storage worked even if the auth keyring wasn't present. The storage would
> not get activated until the keyring file was present. But one could still do
> that after adding the storage config. With this check we would make it a
> requirement to first place the keyring file and then add the storage config.

Actually, I requested the feature to be able to add one through the storage
add and update API/web-interface a long time ago from Alwin, was lost in the
cogs of time though...

So; I do not see that as issue but rather as another small feature we could
finally do.

Handling in the backend should be similar to other secrets, e.g., pbs password
or encryption-key, cifs password, etc.




  reply	other threads:[~2021-04-16 15:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 14:10 Aaron Lauterer
2021-04-16 14:56 ` Thomas Lamprecht
2021-04-16 15:39   ` Aaron Lauterer
2021-04-16 15:48     ` Thomas Lamprecht [this message]
2021-04-16 15:56       ` Aaron Lauterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86b079a3-9bb3-21ae-2dda-95069e5e7a4c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal