From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox_dart_api_client v3 0/2] fix: ios: add support for custom user certificates
Date: Fri, 26 Sep 2025 11:23:55 +0200 [thread overview]
Message-ID: <8685367c-9750-43a5-8e5d-6f3898d0732e@proxmox.com> (raw)
In-Reply-To: <20250924130547.19071-1-s.shaji@proxmox.com>
On 9/24/25 3:05 PM, Shan Shaji wrote:
> The app was not honoring the user installed certificate and was still
> throwing `HandShakeException` when using `IOClient`. Inorder to fix the
> issue used the `cupertino_http` package. This patch series only includes
> the changes specific to iOS. Android related changes can be found here
> [0].
>
> - [0] https://lore.proxmox.com/pve-devel/DCKQF7FSYTGT.HK16P9PBZEDS@proxmox.com/T/#t
>
> History:
> ==============
>
> Changes since v2: Thanks @Dominik
> patch: https://lore.proxmox.com/pve-devel/20250917120616.80136-1-s.shaji@proxmox.com/T/#t
> - Rebased with master.
> - Fixed commit message
>
> changes since v1: https://lore.proxmox.com/pve-devel/DCUXS353OF44.2TCRIG1U97LAK@proxmox.com/T/#m18041c4e36f4188d46a6fa224a61e76ac394abfa
> - Rebased with master
>
>
> Shan Shaji (2):
> fix: ios: use `cupertino_http` package to honor custom user
> certificates
> fix: ios: add explicit throw of `HandshakeException`
>
> lib/src/authenticate.dart | 14 +++++++++++++-
> lib/src/utils_native.dart | 10 +++++++++-
> pubspec.lock | 18 +++++++++++++++++-
> pubspec.yaml | 1 +
> 4 files changed, 40 insertions(+), 3 deletions(-)
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-26 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 13:05 [pve-devel] " Shan Shaji
2025-09-24 13:05 ` [pve-devel] [PATCH proxmox_dart_api_client v3 1/2] fix: ios: use `cupertino_http` package to honor " Shan Shaji
2025-09-24 13:05 ` [pve-devel] [PATCH proxmox_dart_api_client v3 2/2] fix: ios: add explicit throw of `HandshakeException` Shan Shaji
2025-09-26 9:23 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8685367c-9750-43a5-8e5d-6f3898d0732e@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox