From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] ui: dc/Cluster: show errors on 'join' info in the view
Date: Sun, 7 Nov 2021 21:04:37 +0100 [thread overview]
Message-ID: <8641726e-1ad2-f3b6-6022-fb85bc624e8a@proxmox.com> (raw)
In-Reply-To: <20211029091408.1963182-1-d.csapak@proxmox.com>
On 29.10.21 11:14, Dominik Csapak wrote:
> so instead of getting the 'standalone node' message, the grid
> is masked with the actual api error
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * only show error if it does not match the 'standalone' error
>
> not sure if matching the *exact* error message is very robust, but AFAICS,
> this did not change for a while now, and even if we'd change it, it
> would be very apparent, as we could not create a cluster in the gui
> anymore.
>
> www/manager6/dc/Cluster.js | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>
applied, thanks! I made some changes in pve-cluster to return a special error case
for this situation to match on, dropping the error now would be rather a breaking
change (our UI would break too..), else I'd have gone for that.
prev parent reply other threads:[~2021-11-07 20:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 9:14 [pve-devel] " Dominik Csapak
2021-11-07 20:04 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8641726e-1ad2-f3b6-6022-fb85bc624e8a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox