Re: [pve-devel] [PATCH manager v4 1/3] api ceph osd: add OSD index, metadata and lv-info

[Aaron Lauterer <a.lauterer@proxmox.com>]

On 12/7/22 18:23, Alwin Antreich wrote:
> December 7, 2022 2:22 PM, "Aaron Lauterer" <a.lauterer@proxmox.com> wrote:
> 
>> On 12/7/22 12:15, Alwin Antreich wrote:
>>
>>> Hi,
>>
>> December 6, 2022 4:47 PM, "Aaron Lauterer" <a.lauterer@proxmox.com> wrote:
>>> To get more details for a single OSD, we add two new endpoints:
>>
>> * nodes/{node}/ceph/osd/{osdid}/metadata
>> * nodes/{node}/ceph/osd/{osdid}/lv-info
>>> As an idea for a different name for lv-info, `nodes/{node}/ceph/osd/{osdid}/volume`? :)
>>
>> Could be done, as you would expect to get overall physical volume infos from it, right? So that the
>> endpoint won't change, once the underlying technology changes?
> 
> Yes. It sounds more clear to me, as LV could mean something different. :P
> 

Thinking about it a bit more, I am hesitant to rename the API endpoint. It is 
very specific to LVs. Should a new generation of OSDs use something completely 
different in the future, I would rather add a new API call handling it and not 
adapt a currently existing one. Changing an established API endpoint is not 
something that should be done lightly.