From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] superseded: [PATCH pve-cluster v2] fix #6615: rrd: only return populated entries
Date: Wed, 27 Aug 2025 11:05:47 +0200 [thread overview]
Message-ID: <861dc8f8-09c6-456d-9e9d-2b469e0e0903@proxmox.com> (raw)
In-Reply-To: <20250808150814.110051-1-h.laimer@proxmox.com>
superseded-by:
https://lore.proxmox.com/pve-devel/20250827090431.48707-1-h.laimer@proxmox.com/T/#u
On 08.08.25 17:07, Hannes Laimer wrote:
> RRD fetch can include the latest bucket before metrics are flushed,
> resulting in entries with only a timestamp.
>
> This now only returns entries with at least one value.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> since v1, thanks @Fabian:
> - just check count of keys in entry instead of keeping track of when
> something is added
>
> src/PVE/RRD.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/RRD.pm b/src/PVE/RRD.pm
> index 8fe1927..1813cdb 100644
> --- a/src/PVE/RRD.pm
> +++ b/src/PVE/RRD.pm
> @@ -78,7 +78,8 @@ sub create_rrd_data {
> # maybe make this configurable?
> }
> }
> - push @$res, $entry;
> + # 'time' + at least one metric
> + push @$res, $entry if (scalar keys %$entry) > 1;
> }
>
> return $res;
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-27 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 15:08 [pve-devel] " Hannes Laimer
2025-08-11 9:25 ` Dominik Csapak
2025-08-27 8:41 ` Hannes Laimer
2025-08-27 9:05 ` Hannes Laimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861dc8f8-09c6-456d-9e9d-2b469e0e0903@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox