Re: [pve-devel] [PATCH guest-common v14 2/12] add dir mapping section config

[Daniel Kral <d.kral@proxmox.com>]

One small comment inline.

Tested the obvious cases:

- trying to add multiple map entries with the same node for the same 
dirid results in an error in the WebGUI
- adding multiple map entries manually in the file for a dirid will make 
the VM fail to start with an error indicating that there are multiple 
paths for the same dirid and node, but only if it actually uses the 
mountpoint

Else the patch looks good to me, consider this as:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>
Tested-by: Daniel Kral <d.kral@proxmox.com>

On 3/4/25 12:57, Markus Frank wrote:
> Adds a config file for directories by using a 'map' property string for
> each node mapping.
> 
> Next to node & path, there is the optional announce-submounts parameter
> which forces virtiofsd to report a different device number for each
> submount it encounters. Without it, duplicates may be created because
> inode IDs are only unique on a single filesystem.
> 
> example config:
> ```
> some-dir-id
> 	map node=node1,path=/mnt/share/,announce-submounts=1
> 	map node=node2,path=/mnt/share/,

nit: the trailing comma in the last map line will fail to display all 
directory mappings in the WebGUI because parsePropertyString() will 
return undefined in the ResourceMapTree component.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel