From: alexandre derumier <aderumier@odiso.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config.
Date: Sun, 4 Apr 2021 14:12:24 +0200 [thread overview]
Message-ID: <85609aca-dbda-0545-2c1e-16128cc38072@odiso.com> (raw)
In-Reply-To: <f3f838b8e62037dac9bbf1cd544cdfc52687f27c.camel@odiso.com>
Hi,
if you really want to keep the current pending behaviour,
I think the only way is add new pending values,
like "hostname" example , and for ipconfig, add the mac attribute.
so, this should give something like:
name change: name(pending
-->fastplug)--->hostname(pending)---regenerate-->hostname
nic hotplug : net0 (pending)---->net0 (main config
ok)--->ipconfi0g:...,newmac.(pending)---generate--->ipconfig0
Note that we shouldn't allow revert of ipconfig0. (It's not exposed to
gui, but we can do revert from command line)
On 02/04/2021 11:22, aderumier@odiso.com wrote:
> Maybe, another way,
> instead writing [cloudnit:special] section,
>
> we could write this config section inside the drive image directly when
> we generate it (to avoid to reparse format generate config)
>
> so we could read the drive to display the diff in the gui
> (we already have an cloudinit dump api, don't seem to be slow)
>
> what do you think about this ?
>
>
> Le jeudi 01 avril 2021 à 12:22 +0200, aderumier@odiso.com a écrit :
>> Le jeudi 01 avril 2021 à 10:54 +0200, Thomas Lamprecht a écrit :
>>> actually, why isn't the pending section enough for this?
>>>
>>> If stuff can be hot plugged then we can do so and if only that
>>> changed we
>>> can just remove it from pending, as normally?
>> Well, for example, if you change the vm name , how to you manage that
>> ?
>> do you want to keep it as pending until we regenerate cloudinit
>> drive?
>>
>> or more complex, if you change the mac address of the vm. (so
>> unplug/replug the nic)
>> for the nic, you don't want to keep it as pending, as technically, is
>> really plugged.
>>
>> or if you change the storage of the cloudinit drive, currently they a
>> no way to known if we need to regenerate it.
>>
>> The main problem is that pending section, is more for pending qemu
>> change,
>> not pending cloudinit config drive regeneration.
>>
>> For me, both are differents.
>>
>>
>> Currently,it's working well when vm is offline, because we don't have
>> any pending, and we regenerate the disk at vm startup.
>>
>>
>> (I'm really looking to use cloudinit for online config changes, like
>> for containers)
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
next prev parent reply other threads:[~2021-04-04 12:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 15:11 [pve-devel] [PATCH qemu-server 0/6] cloudinit pending behaviour change Alexandre Derumier
2021-03-28 15:11 ` [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config Alexandre Derumier
2021-03-31 14:10 ` Mira Limbeck
2021-04-01 8:54 ` Thomas Lamprecht
2021-04-01 10:22 ` aderumier
2021-04-02 9:22 ` aderumier
2021-04-04 12:12 ` alexandre derumier [this message]
2021-03-28 15:11 ` [pve-devel] [PATCH qemu-server 2/6] generate cloudinit drive on offline plug Alexandre Derumier
2021-03-28 15:12 ` [pve-devel] [PATCH qemu-server 3/6] cloudinit: make cloudnit options fastplug Alexandre Derumier
2021-03-28 15:12 ` [pve-devel] [PATCH qemu-server 4/6] api2: add cloudinit config api Alexandre Derumier
2021-03-31 14:13 ` Mira Limbeck
2021-03-31 17:32 ` aderumier
2021-04-01 0:16 ` aderumier
2021-03-28 15:12 ` [pve-devel] [PATCH qemu-server 5/6] api2: add cloudinit_update Alexandre Derumier
2021-03-28 15:12 ` [pve-devel] [PATCH qemu-server 6/6] add cloudinit hotplug Alexandre Derumier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85609aca-dbda-0545-2c1e-16128cc38072@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox