From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer 0/2] fix 2 bugs related to hdsize selection
Date: Wed, 20 Apr 2022 14:12:49 +0200 [thread overview]
Message-ID: <855ae3c2-f430-a85b-b68e-bee2e48c173b@proxmox.com> (raw)
In-Reply-To: <20220419120231.2161474-1-s.ivanov@proxmox.com>
On 19.04.22 14:02, Stoiko Ivanov wrote:
> noticed that these 2 bugs were still open in bugzilla (and assigned to me).
>
> The issues are independent of each other - but the fixes touch the same part
> of the code - hence I'm sending them in a common series.
>
> roughly tested with a VM (scp'ing the updated proxinstall from the
> second debug shell)
>
>
> Stoiko Ivanov (2):
> fix #3188: update hdsize spin-button on disk-selection change
> fix #3587: make hdsize configurable for btrfs setups
>
> proxinstall | 95 ++++++++++++++++++++++++++++++++++++-----------------
> 1 file changed, 65 insertions(+), 30 deletions(-)
>
applied, thanks! Made some followups on top to avoid the relatively expensive recreation
of the GTK::Adjustment element for each view every time a disk selection change and some
improvements/clean-ups in the pre-existing code too.
prev parent reply other threads:[~2022-04-20 12:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 12:02 [pve-devel] " Stoiko Ivanov
2022-04-19 12:02 ` [pve-devel] [PATCH installer 1/2] fix #3188: update hdsize spin-button on disk-selection change Stoiko Ivanov
2022-04-19 12:02 ` [pve-devel] [PATCH installer 2/2] fix #3587: make hdsize configurable for btrfs setups Stoiko Ivanov
2022-04-20 12:12 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=855ae3c2-f430-a85b-b68e-bee2e48c173b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox