Re: [pve-devel] [PATCH V3 qemu-server 3/3] migration : add del_nets_bridge_fdb

[Mira Limbeck <m.limbeck@proxmox.com>]

On 8/24/22 18:26, Alexandre Derumier wrote:
> at the end of a live migration, we need to remove old mac entries
> on source host (vm is not yet stopped), before resume vm on target host
>
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>   PVE/QemuMigrate.pm                    |  1 +
>   PVE/QemuServer.pm                     | 20 ++++++++++++++++++++
>   test/MigrationTest/QemuMigrateMock.pm |  3 +++
>   3 files changed, 24 insertions(+)
>
> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
> index d52dc8d..b72a3fe 100644
> --- a/PVE/QemuMigrate.pm
> +++ b/PVE/QemuMigrate.pm
> @@ -1157,6 +1157,7 @@ sub phase3_cleanup {
>   
>       # transfer replication state before move config
>       $self->transfer_replication_state() if $self->{is_replicated};
> +    PVE::QemuServer::del_nets_bridge_fdb($conf, $vmid);

I'm currently going through this patch series, and I'm wondering. 
Wouldn't it make more sense to delete the bridge fdb entries as part of 
the VM shutdown instead?

This way those would be cleaned up whenever the VM is stopped (and the 
tap device gets destroyed). No special handling for migrations needed, 
unless I'm missing something?