[pve-devel] [PATCH manager] ui: improve ACME edit/apply button visibilty

[pve-devel] [PATCH manager] ui: improve ACME edit/apply button visibilty

[Dominik Csapak]

multiple users were confused[0], as they did not interpret the 'icon only'
in the toolbar as a button (and it did not help that we prevented
the cursor to change)

to improve it, make the button a normal one again, and add some
text for context (this is more inline what we do elsewhere in toolbars)

0: https://forum.proxmox.com/threads/acme-over-dnschallenge-failing.71902

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/node/ACME.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js
index cfe9cc12..635787f6 100644
--- a/www/manager6/node/ACME.js
+++ b/www/manager6/node/ACME.js
@@ -365,6 +365,7 @@ Ext.define('PVE.node.ACME', {
 	formulas: {
 	    canOrder: (get) => !!get('account') && get('domaincount') > 0,
 	    editBtnIcon: (get) => 'fa black fa-' + (get('accountEditable') ? 'check' : 'pencil'),
+	    editBtnText: (get) => get('accountEditable') ? gettext('Apply') : gettext('Edit'),
 	    accountTextHidden: (get) => get('accountEditable') || !get('accountsAvailable'),
 	    accountValueHidden: (get) => !get('accountEditable') || !get('accountsAvailable'),
 	},
@@ -606,10 +607,9 @@ Ext.define('PVE.node.ACME', {
 	{
 	    xtype: 'button',
 	    iconCls: 'fa black fa-pencil',
-	    baseCls: 'x-plain',
-	    userCls: 'pointer',
 	    bind: {
 		iconCls: '{editBtnIcon}',
+		text: '{editBtnText}',
 		hidden: '{!accountsAvailable}',
 	    },
 	    handler: 'toggleEditAccount',
-- 
2.30.2

[pve-devel] applied: [PATCH manager] ui: improve ACME edit/apply button visibilty

[Thomas Lamprecht]

On 09.09.21 16:36, Dominik Csapak wrote:
> multiple users were confused[0], as they did not interpret the 'icon only'
> in the toolbar as a button (and it did not help that we prevented
> the cursor to change)
> 
> to improve it, make the button a normal one again, and add some
> text for context (this is more inline what we do elsewhere in toolbars)
> 
> 0: https://forum.proxmox.com/threads/acme-over-dnschallenge-failing.71902
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/node/ACME.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!