[pve-devel] [PATCH v2 manager] ui: utils: monitor_ceph_installed: avoid setting nodename to localhost

[pve-devel] [PATCH v2 manager] ui: utils: monitor_ceph_installed: avoid setting nodename to localhost

[Aaron Lauterer]

If a user is accessing the Ceph panel via Datacenter -> Ceph, then the
install & config wizard might be shown. The nodename that is passed to
the wizard  will decide the ID of the initial MON and MGR services.

Therefore, don't fall back to 'localhost' but the actual name of the
node to which we are connected to. The result will be that the first MON
and MGR will have the expected ID instead of 'localhost'.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---

changes since  ui: CephInstallWizard: avoid using localhost on first configuration:

* set the node name in the utils function that calls the wizard and not
  within the wizard.

 www/manager6/Utils.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 94e75d5c..d5dd2999 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1722,7 +1722,7 @@ Ext.define('PVE.Utils', {
 	    rstore,
 	    /not (installed|initialized)/i,
 	    (_, error) => {
-		nodename = nodename || 'localhost';
+		nodename = nodename || Proxmox.NodeName;
 		let maskTarget = maskOwnerCt ? view.ownerCt : view;
 		rstore.stopUpdate();
 		PVE.Utils.showCephInstallOrMask(maskTarget, error.statusText, nodename, win => {
-- 
2.30.2

[pve-devel] applied: Re: [PATCH v2 manager] ui: utils: monitor_ceph_installed: avoid setting nodename to localhost

[Thomas Lamprecht]

On 20/04/2023 14:31, Aaron Lauterer wrote:
> If a user is accessing the Ceph panel via Datacenter -> Ceph, then the
> install & config wizard might be shown. The nodename that is passed to
> the wizard  will decide the ID of the initial MON and MGR services.
> 
> Therefore, don't fall back to 'localhost' but the actual name of the
> node to which we are connected to. The result will be that the first MON
> and MGR will have the expected ID instead of 'localhost'.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> 
> changes since  ui: CephInstallWizard: avoid using localhost on first configuration:
> 
> * set the node name in the utils function that calls the wizard and not
>   within the wizard.
> 
>  www/manager6/Utils.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!